search

ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles
Other
98 stars 14 forks source link

Make plotting happy by adding moments member #181

Closed Jaeyoung-Lim closed 2 years ago

Jaeyoung-Lim commented 2 years ago

Problem Description As reported in https://github.com/ethz-asl/data-driven-dynamics/issues/180, plotting has been failing with the following error

Traceback (most recent call last):
  File "Tools/parametric_model/generate_parametric_model.py", line 117, in <module>
    start_model_estimation(**vars(arg_list))
  File "Tools/parametric_model/generate_parametric_model.py", line 99, in start_model_estimation
    model.compute_residuals()
  File "/home/jaeyoung/dev/data-driven-dynamics/Tools/parametric_model/src/models/dynamics_model.py", line 487, in compute_residuals
    error_y_moments = y_moments_pred - self.y_moments
AttributeError: 'MultiRotorModel' object has no attribute 'y_moments'
Makefile:35: recipe for target 'estimate-model' failed
make: *** [estimate-model] Error 1

This is a quick WIP fix where the plotting tools are back for being happy now, but the axis of the data seems to be swapped (as expected) @pascalau FYI

Figure_1

Jaeyoung-Lim commented 2 years ago

Merging as this does not make the situation worse :smile:

Will follow up with a proper fix