search

ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles
Other
91 stars 13 forks source link

Fix Ci pipeline #235

Closed manumerous closed 7 months ago

manumerous commented 7 months ago

Removed depreciated make install-full-dependencies since the vpselector is not just a pip package in requirements.txt

manumerous commented 7 months ago

It seems to be a timeout issue. Could be that the runner is running out of memory or a timeout is triggered. Have to investigate further. The same step works locally for me and @sjschlapbach the local dependencies installation worked.

manumerous commented 7 months ago

@Jaeyoung-Lim do we have access to some asl runners?

Jaeyoung-Lim commented 7 months ago

@manumerous Interesting, although the asl runners would have even less memory.

manumerous commented 7 months ago

It is just a suspicion my now. In the pipeline there is no obvious fail, the script is just terminated 🤔

Jaeyoung-Lim commented 7 months ago
manumerous commented 7 months ago

Checked for the CI timeout. it is set to 45 min. So I doubt that was the issue. I think it was likely a memory issue due to us installing more dependencies through the vpselector (especially pyqt is heavy). Switching to the custom ASL runner seems to solve this issue.

manumerous commented 7 months ago

Please go ahead and merge directly if you agree with the changes.