Plotting / data dump needs to be separated with model estimation

ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles

Other

99 stars 14 forks source link

Plotting / data dump needs to be separated with model estimation #48

Closed Jaeyoung-Lim closed 3 years ago

Jaeyoung-Lim commented 3 years ago

Problem Description Currently Plotting / data dumps are part of a model estimation method.

https://github.com/ethz-asl/data-driven-dynamics/blob/b8e3b29d70b1b3f8f8887fd30bb173333fb9ba16/Tools/parametric_model/src/models/quad_plane_model.py#L117

This makes it hard to do any manipulation on the plots or estimation results AFTER a model estimation is done

manumerous commented 3 years ago

Yes this was always ment to be a temporary solution. I will take it into account when I change the structure :)

manumerous commented 3 years ago

The model plots are not a part of the model estimation method anymore. Since a while they are all called from their own function.

Even though that structure can still be improved in the future by making it for example configurable which plots are shown the main issue mentioned here is solved.

Can we close this @Jaeyoung-Lim ?

Jaeyoung-Lim commented 3 years ago

Sure!