search

ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles
Other
99 stars 14 forks source link

Add pytest to CI pileline #57

Closed manumerous closed 3 years ago

manumerous commented 3 years ago

This one should be fairly self explanatory. Not sure if the chmod is actually needed, but I was also not sure how to test it without uploading it here lol.

manumerous commented 3 years ago

Nope, you need different names for each steps.

This one should be fairly self explanatory. Not sure if the chmod is actually needed, but I was also not sure how to test it without uploading it here lol.

I see. Should we maybe even make a new job called for example test? Strictly speaking we are testing functionalities using pytest and not whether the code builds i would say.

Jaeyoung-Lim commented 3 years ago

@manumerous The intension of that test was to start running the pipeline, so I would say just use it (the sysid test is not buildung anything, just installing python dependencies) you need this anyway for your pipeline

Jaeyoung-Lim commented 3 years ago

@manumerous Can you remove bionic from the sysID test?

manumerous commented 3 years ago

Why would you want to remove that? If there is a need from asl to support that and if we check if building works on bionic why would you not want to check the SYSID pipeline test? Do we need to safe on actions?

Jaeyoung-Lim commented 3 years ago

@manumerous Because it is broken 😄

It is a waste of resources to run something we know that is broken. Lets fix it in https://github.com/ethz-asl/data-driven-dynamics/pull/55