search

ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles
Other
99 stars 14 forks source link

Improve handling on model config file paths #87

Closed Jaeyoung-Lim closed 3 years ago

Jaeyoung-Lim commented 3 years ago

Problem Description This PR addresses the issue that the configuration path was hardcoded within the code.

The assumption that the config file is under a specific relative path is only valid for the default config files. This makes it harder to handle cases where the configuration files are in other places.

This PR removes the default config file path from the source, and handles it by using default config file names that are the same as the model name. The user can always override the config file by speficying the path to the config file

make estimate-model --model=<model_type> --config=<path_to_config_file> log

Additional Context

Jaeyoung-Lim commented 3 years ago

@manumerous Thanks for the feedback! Done