search

ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles
Other
99 stars 14 forks source link

Tiltwing improvement #92

Closed manumerous closed 3 years ago

manumerous commented 3 years ago

This PR contains various improvements, bug fixes and tests mainly for the tiltwing model. Some of the changes also affect the other models though.

Sorry that its so much in one go to review. This is almost everything from the crunch mode in one PR.

manumerous commented 3 years ago

Thanks for your Review Jay! Do you by chance have an idea why the CI test fails by some XCB component (related to X-server) missing. Since we don't test the visual dataframe selector in the container I do not quite understand why this error pops up. Also I have never seen it before I rebased.

Jaeyoung-Lim commented 3 years ago

@manumerous Something is trying to render something on the display and is failing.

Probably it has something with the display being handled differently in Qt. Have you tried removing pyQt?

manumerous commented 3 years ago

@manumerous Something is trying to render something on the display and is failing.

Probably it has something with the display being handled differently in Qt. Have you tried removing pyQt?

We can not remove it from the installation of the dependencies without it failing. So but i am a bit surprised that this is the case in the first place since the visual dataframe selector, requiring pyqt, is only imported when the function is called.