ethz-asl / data-driven-dynamics

Data Driven Dynamics Modeling for Aerial Vehicles
Other
99 stars 14 forks source link

Advance ratio in rotor model #96

Closed Jaeyoung-Lim closed 3 years ago

Jaeyoung-Lim commented 3 years ago

@manumerous In the report, the rotor model includes advance ratio computation (as shown below)

image

However, the rotor feature doesn't seem to be containing the advance ratio in the model: https://github.com/ethz-asl/data-driven-dynamics/blob/5624810bd604f3eeaacf33a3d1155b514f8e6e1d/Tools/parametric_model/src/models/rotor_models/rotor_model.py#L106-L107

Probably I am missing something?

manumerous commented 3 years ago

I realized that I did not yet add the adaption from the high entropy branch that fixed the missing diameter. It is updated in PR #100 Here the two comulms of X_thrust are representative of the two summands in formula 4.7 if you factor in all the components. Hope that clarifies the issue.

Jaeyoung-Lim commented 3 years ago

Fixed by https://github.com/ethz-asl/data-driven-dynamics/pull/100