search

ethz-asl / depth_segmentation

A collection of segmentation methods working on depth images
BSD 3-Clause "New" or "Revised" License
129 stars 34 forks source link

Semantic instance segmentation integration #35

Closed margaritaG closed 5 years ago

margaritaG commented 5 years ago

Integrated optional semantic instance segmentation through mask_rcnn_ros and refactored to favour code re-use across the two modalities.

ffurrer commented 5 years ago

Can you also try to fix the build please, (updated the dependencies.rosinstall file and as mentioned above make it work also without mask_rcnn)

margaritaG commented 5 years ago

@ffurrer @ntonci I fixed the build with a conditional find_package in CMakeLists, and addressed the review comments.

margaritaG commented 5 years ago

@ntonci Unless you had some specific tests in mind, I have verified that both the classic and semantic instance segmentation modes work as usual on data from the SceneNN dataset, jointly with the GSM.