ethz-asl / ethzasl_brisk

Brisk. The feature.
20 stars 11 forks source link

Bugfix: Correct pointer arithmetic when storing score #90

Closed jschornick closed 9 years ago

jschornick commented 9 years ago

The Scores cv::Mat has elements of integer size. The pointer arithmetic should be based on simple row/col offset calculation. It should definitely not be using the stride of the source image.

This worked in the past since this method is only meant to be called with grayscale images, where one byte per element meant (stride == cols).

ethzasl-jenkins commented 9 years ago

Can one of the admins verify this patch?

jschornick commented 9 years ago

@simonlynen

Accidentally discovered this when doing something silly in an unrelated test. I believe the fix is correct, but you should definitely double check my interpretation of what's going on.

simonlynen commented 9 years ago

lgtm

simonlynen commented 9 years ago

test this please