ethz-asl / ethzasl_brisk

Brisk. The feature.
20 stars 11 forks source link

Key point bucketing #93

Closed mfehr closed 9 years ago

mfehr commented 9 years ago

@simonlynen Regarding the color frame landmark problem: In 3D there is still something wrong. (Cyan = color frame landmarks)

landmark_matches_241936525359

good

bad

ethzasl-jenkins commented 9 years ago

Can one of the admins verify this patch?

simonlynen commented 9 years ago

ok to test

simonlynen commented 9 years ago

Thanks for adding this. I added some comments, let me know when I can take another look.

mfehr commented 9 years ago

@simonlynen I changed the bucket counter stuff a bit. I want to keep it a member variable, but I changed the reset function to a function that just resets the counter and doesn't reallocate the memory. This way the KeyPointBuckets object can be reused for images of the same size and no memory needs to be reallocated. ptal

simonlynen commented 9 years ago

lgtm