search

ethz-asl / ethzasl_icp_mapping

3D mapping tools for robotic applications
273 stars 156 forks source link

Eigen includes #37

Closed aleksandaratanasov closed 9 years ago

aleksandaratanasov commented 9 years ago

Incorrect includes of Eigen inside ethzasl_icp_mapping/ethzasl_extrinsic_calibration/src/optimize.cpp.

aleksandaratanasov commented 9 years ago

The includes should be something like:

#include <eigen3/Eigen/Eigen>
#include <eigen3/Eigen/LU>

depending on the version installed. In my case I have ROS Indigo and try to compile the catkanized icp_mapping packages. The fix I have posted in this comment is a possible solution to the issue.

HannesSommer commented 9 years ago

No, this is wrong. The build system should add the eigen3 as part of the include list. (see e.g. http://eigen.tuxfamily.org/dox/GettingStarted.html). Your PR #36 is missing this. It requires something like 

include_directories(${EIGEN3_INCLUDE_DIR})

The catkinization branch is outdated. The necessary changes are already within the indigo_devel branch. Please try the reintegrate/master_into_indigo_devel branch and test if it works for you.

aleksandaratanasov commented 9 years ago

Ah, you are right. I actually added the include_directories by myself but forgot about that. :D Will try your suggestion. Thanks!