search

ethz-asl / ethzasl_icp_mapping

3D mapping tools for robotic applications
273 stars 156 forks source link

Fix fieldTypes dim when converting to PMCloud #68

Closed nicolapiccinelli closed 5 years ago

nicolapiccinelli commented 6 years ago

In rosMsgToPointMatcherCloud there is a missing push_back on fieldTypes vector when rosMsg.fields.name is equal to "rgb" or "rgba".

The assertion on size equality fails as follow:

/home/andrea/catkin_ws/src/ethzasl_icp_mapping/libpointmatcher_ros/src/point_cloud.cpp:108: typename PointMatcher<T>::DataPoints PointMatcher_ros::rosMsgToPointMatcherCloud(const PointCloud2&, bool) [with T = float; typename PointMatcher<T>::DataPoints = PointMatcher<float>::DataPoints; sensor_msgs::PointCloud2 = sensor_msgs::PointCloud2_<std::allocator<void> >]: Assertion 'fieldTypes.size() == rosMsg.fields.size()' failed.

ethzasl-jenkins commented 6 years ago

Can one of the admins verify this patch?

HannesSommer commented 6 years ago

ok to test