search

ethz-asl / ethzasl_ptam

Modified version of Parallel Tracking and Mapping (PTAM)
http://wiki.ros.org/ethzasl_ptam
235 stars 184 forks source link

Added ARM support #22

Closed paralin closed 11 years ago

paralin commented 11 years ago

Fixed some build problems preventing PTAM to build on ARM systems.

Tested on Odroid X2 --> everything working, also fixes a grid drawing issue.

simonlynen commented 11 years ago

Please address the comments. Otherwise lgtm.

paralin commented 11 years ago

I had to remove -msse3 because that option is not supported on ARM processors (nor is it relevant). What do you mean "it is given above"?

simonlynen commented 11 years ago

You are adding msse3 for arch 686. This is not needed. Fine with removing it above. It was superfluous there in the first place. Our fault.

paralin commented 11 years ago

Fixed. Thanks for the note.

simonlynen commented 11 years ago

arch native will emit sse so you don't need to add it. http://gcc.gnu.org/onlinedocs/gcc/i386-and-x86_002d64-Options.html

Sure it ARM doesn't have this instruction set.

paralin commented 11 years ago

There are currently 3 issues where if statements are not operating correctly. This will be fixed in the next commit tonight.

simonlynen commented 11 years ago

OK, push them here. I can then merge.

paralin commented 11 years ago

Fixed, should be ready now for pull.

simonlynen commented 11 years ago

minor comment, otherwise lgtm.