ethz-asl / ethzasl_xsens_driver

Driver for xsens IMUs
BSD 2-Clause "Simplified" License
102 stars 112 forks source link

Update for use with Noetic and Python3 #119

Open ghost opened 2 years ago

ghost commented 2 years ago

I'm currently converting our code base to Noetic and python3, and have in the process done so for this project as well. I'm under quite a bit of pressure, so I have not had the chance to test this outside of our specific setup, which is an MTi-100 reporting Acc, Gyro, Mag, and Temp. I'm sorry I'm not able to follow this through a bit more, but I hope it can be a good starting point.

Since implicit relative imports don't work in python3, I have created a module folder with implementation files with a _ prepended. This is the convention we use to solve this issue, but it does have the disadvantage that the entire history is lost to git :/

Other than the completely standard changes, I changed the classes in mtdef to inherit from the Enum class instead of the manually implemented enum functionality, which didn't work under python3 (the getName function specifically).

peci1 commented 1 year ago

PR #124 was merged which adds Noetic support (and keeps Melodic supported, too).