search

ethz-asl / ethzasl_xsens_driver

Driver for xsens IMUs
BSD 2-Clause "Simplified" License
102 stars 111 forks source link

Feat/configurable covariance diagonals #65

Closed reinzor closed 6 years ago

reinzor commented 6 years ago

Enables the user to alter the covariance of the various signals.

fcolas commented 6 years ago

It's great, many thanks for your contribution. May I ask that you add those parameters in the launch file too?

reinzor commented 6 years ago

Updated :)

fcolas commented 6 years ago

Many thanks but it doesn't work for me: the test of line 38 fails, probably a conversion issue between the string representation and the actual list.

reinzor commented 6 years ago

Sorry, I didn't test the launch file. I updated the launch file to use rosparam with subst_value=True, now the parameters are properly loaded via args of the launch file

reinzor commented 6 years ago

ping :)

fcolas commented 6 years ago

Many thanks for your contribution, it's greatly appreciated.