search

ethz-asl / fw_px4_plottools

Plotting tools for reading and showing Pixhawk uLog logs in Matlab
32 stars 22 forks source link

Add IridiumSBD status plots #13

Closed acfloria closed 6 years ago

acfloria commented 6 years ago

Add plots for the SatCom status.

@philipoe @tstastny can one of you review it?

philipoe commented 6 years ago

IMHO the fw_px4_plottools repository is not safety critical, so we don't need to do code reviews necessarily here. Also, you are actually the only one who knows the iridium sbd stuff. Just make sure everything is tested well. Do you both agree?

acfloria commented 6 years ago

Ok, I ran it with the FAT log file and it worked.

I think for just adding plots we do not need to make a review. But if we change for example how the data is loaded then it would make sense.