search

ethz-asl / fw_px4_plottools

Plotting tools for reading and showing Pixhawk uLog logs in Matlab
32 stars 22 forks source link

Replace the 2017a string definition by the 2016b one #3

Closed acfloria closed 7 years ago

acfloria commented 7 years ago

Use string('text') instead of "text".

@ASM3 please check if it runs now for you and if not please post the error message.

ASM3 commented 7 years ago

Still has "string" related issues. This time it is the "exist" function (this is where I stopped in the last try)

Error details: Undefined function 'exist' for input arguments of type 'string'.

Error in logconv/ImportPX4LogData (line 384) if exist(csv_file, 'file') == 2

Error in logconv (line 103) ImportPX4LogData();

acfloria commented 7 years ago

@ASM3 I can you test it again.

ASM3 commented 7 years ago

Pushed some small fixes, it work on my machine now. Nevertheless the conversion is very slow.

acfloria commented 7 years ago

I added a timer. Can you please run it again and report me the times it took for you to convert the file? It for sure can be sped up but for now it works on your machine so I will merge after you reported the times.

ASM3 commented 7 years ago

I restarted the computer and it helped a bit... nevertheless, here are the timer values (file size 25MB): INFO: Start importing the log data. INFO: Converting the ulog file to csv took 43.1684 s. INFO: Starting to import the csv data into matlab. INFO: Importing the csv data to matlab took 181.4073 s. INFO: Finished importing the log data. INFO: Not cropping the logging data.

acfloria commented 7 years ago

Importing the csv data took the same amount of time for me. However the ulog to csv conversion was done on linux within 10 seconds. When I test it on windows the ulog conversion also takes around 40 seconds.

@ASM3 once you parsed the data you can switch to loading mode 2 which directly loades the .mat files. This should be significantly faster.