search

ethz-asl / hand_eye_calibration

Python tools to perform time-synchronization and hand-eye calibration.
BSD 3-Clause "New" or "Revised" License
438 stars 114 forks source link

add mestimator to optimization conifg #53

Closed ffurrer closed 7 years ago

ffurrer commented 7 years ago

@HannesSommer is it correct, that the mestimator is off by default? Wasn't sure by looking at your code.

HannesSommer commented 7 years ago

Hm, good question. You mean of oomact itself? Maybe not. Problem is that it is hard to tell which one and with which parameters. One could make setting one mandatory. So not mentioning it would be an error. What do you think? For this repo this PR sets a default. I would need to check whether 10 is reasonable. Would be interesting who this affects the paper's results.

ffurrer commented 7 years ago

Yup I was talking about oomact, nah, I think it's fine with the default, like this and yes, we should check this value again :).