search

ethz-asl / image_undistort

A compact package for undistorting images directly from kalibr calibration files. Can also perform dense stereo estimation
249 stars 93 forks source link

Added opencv requirements #25

Closed cwitting closed 6 years ago

cwitting commented 6 years ago

An update to cv_bridge broke some dependencies, this should fix it. For reference: https://discourse.ros.org/t/opencv-3-3-1-is-breaking-builds-in-kinetic/3384/5 https://github.com/ros-perception/vision_opencv/issues/193 https://github.com/opencv/opencv/pull/10299

Just don't compile with -DCMAKE_BUILD_TYPE=RelWithDebInfo

It will break open cv dependencies.

ethzasl-jenkins commented 6 years ago

Can one of the admins verify this patch?

helenol commented 6 years ago

add to whitelist

helenol commented 6 years ago

Hmm this is breaking the build in indigo then... Could you put this code in an if statement only if the ros version is kinetic?

cwitting commented 6 years ago

@helenol Don't think I will have the time to make this change before after Christmas.

helenol commented 6 years ago

@cwitting NP I'll take care of it. :)

ZacharyTaylor commented 6 years ago

Same issue taken care of in #30 closing