Fix docker entrypoint to always set environment - Githubissues

ethz-asl / kalibr

The Kalibr visual-inertial calibration toolbox

Other

4.37k stars 1.4k forks source link

Fix docker entrypoint to always set environment #534

Closed asmorkalov closed 1 year ago

asmorkalov commented 2 years ago

Current Dockerfiles propose incorrect environment setup. The second /bin/bash call in chain does not inherit environment from the first one. Proposed patch fixes issue with devel/setup.bash and adds kalibr_xxx tools to PATH.

ethzasl-jenkins commented 2 years ago

Can one of the admins verify this patch?

goldbattle commented 2 years ago

Can you fix the build errors?

Step 7/8 : ADD docker_entrypoint.bash /docker_entrypoint.sh
ADD failed: file not found in build context or excluded by .dockerignore: stat docker_entrypoint.bash: file does not exist

Additionally, can you provide what I need to change in the wiki install instructions? Does the user just now not have to run source devel/setup.bash when they enter the container? Thanks!