search

ethz-asl / kalibr

The Kalibr visual-inertial calibration toolbox
Other
4.28k stars 1.39k forks source link

Feature Request: Linting #551

Closed bagavi closed 2 years ago

bagavi commented 2 years ago

I was wondering if the cpp part of can be linted. This will be very useful to work with modern editors.

Possible option

  1. Include a standard .clang-format clang-format.txt at the top folder.
  2. Run find . -regex '.*\.\(cpp\|hpp\|cc\|cxx\)' -exec clang-format -style=file -i {} \; at the top folderl

PS: If all python code is moved to python3, we could perhaps lint that next :)

goldbattle commented 2 years ago

This is probably too big of a change since there is a lot of packages that are used in other ASL projects (e.g., these). Thus after formating, updating them from upstream repos might be an issue (this has yet to ever been done in many years through...).

Will leave this issue open for any other contributors to chime in on if this is desired.

goldbattle commented 2 years ago

Closing for now.