search

ethz-asl / kalibr

The Kalibr visual-inertial calibration toolbox
Other
4.18k stars 1.37k forks source link

add XYZ axis labels + camera names to 3D plot #653

Closed mandulaj closed 5 months ago

mandulaj commented 7 months ago

The Axis in the plot are confusing. Adding labels also to differentiate the cameras makes it much easier to orient.

ethzasl-jenkins commented 7 months ago

Can one of the admins verify this patch?

goldbattle commented 7 months ago

Could you add a screen shot of what it looks like now? Thanks!

mandulaj commented 7 months ago

Of course, here is the plot with XYZ axis labeled and a accompanying camera label for each of the poses:

image

mandulaj commented 7 months ago

BTW: It seems the Build errors in Ubuntu 16 and 18 are related to some unauthenticated packages:

E: There were unauthenticated packages and -y was used without --allow-unauthenticated

goldbattle commented 7 months ago

These look nice. Could you push a fix for the two dockers too? Many thanks!

mandulaj commented 7 months ago

@goldbattle I made a pull request with the Docker packages fix in #655. It built on my system so lets see if it passes the build test on Github.

I would consider pushing the images to a registry (either Dockerhub or Github) so that they don't have to be rebuild every time. Let me know if you would like some help setting this up.