ethz-asl / maplab

A Modular and Multi-Modal Mapping Framework
https://maplab.asl.ethz.ch
Apache License 2.0
2.63k stars 724 forks source link

Strip Voxblox from Maplab to expedite ROS2 port #168

Closed anamud closed 5 years ago

anamud commented 5 years ago

Is Voxblox a show-stopping dependency for Maplab?

I am porting Maplab to ROS2 and would like to avoid porting Voxblox. I am mostly interested in VIO with LC on sparse maps. I read this humorous description of maplab vs voxblox and am assuming Voxblox is not required for my case. Is this assumption correct?

mfehr commented 5 years ago

Hi @anamud Short answer: it's doable, but it's as easy as just dropping the dense reconstruction plugin.

Algorithmically maplab doesn't need voxblox to perform any of it's VIO tasks and it is only used in the dense reconstruction plugin. The issue is the resource system, which supports storing and attaching voxblox maps to the VIMaps, this part is quite deeply embedded. We also use some of the voxblox types for other dense reconstruction algorithms. So you would need to:

Keep us posted about the ROS2 upgrade, we'd be interested to know how it goes.

anamud commented 5 years ago

Hi @mfehr, thanks for the helpful info. I will proceed with stripping voxblox out now.