ethz-asl / maplab

A Modular and Multi-Modal Mapping Framework
https://maplab.asl.ethz.ch
Apache License 2.0
2.63k stars 724 forks source link

Feature/training data generation #231

Closed LBern closed 4 years ago

LBern commented 4 years ago

General

This PR introduces a new flag to switch the lc logic whether we want to merge the landmarks or insert an edge into the pose graph.

Changelog

mfehr commented 4 years ago

@LBern the launch files and calibrations for the lidar stick have moved to maplab-launch. The idea was to eventually remove all the sensor specific stuff from the maplab node folder.

LBern commented 4 years ago

@LBern the launch files and calibrations for the lidar stick have moved to maplab-launch. The idea was to eventually remove all the sensor specific stuff from the maplab node folder.

hmmmm i see. Although I don't really like this state of inconsistency with the other launch files at the moment.

mfehr commented 4 years ago

Agreed, it's not nice, but the alternative would have been me adapting launch files for sensors/data I don't have or need resulting in untested, potentially unnecessary files in the maplab-launch package. How about whenever someone actually uses one he ports it?

ethzasl-jenkins commented 4 years ago

Test PASSed.

ethzasl-jenkins commented 4 years ago

Test PASSed.

ethzasl-jenkins commented 4 years ago

Test PASSed.