search

ethz-asl / maplab

A Modular and Multi-Modal Mapping Framework
https://maplab.asl.ethz.ch
Apache License 2.0
2.64k stars 724 forks source link

Remove strange intensity scaling #267

Closed LBern closed 4 years ago

LBern commented 4 years ago

General

This PR removes a max scaling factor for intensities which at the moment does not make any sense. Now the resources are stored with untouched intensity values:

Screenshot from 2020-07-23 17-05-45

ethzasl-jenkins commented 4 years ago

Test PASSed.

floriantschopp commented 4 years ago

Did you try finding out why this was there in the first place? Are the intensities from e.g. Velodyne differently scaled?

LBern commented 4 years ago

Did you try finding out why this was there in the first place? Are the intensities from e.g. Velodyne differently scaled?

I believe that I added that to handle strange intensity outliers, but now I think this doesn't make any sense at all. Intensities should be stored untouched and certainly not scaled like that.