ethz-asl / maplab

A Modular and Multi-Modal Mapping Framework
https://maplab.asl.ethz.ch
Apache License 2.0
2.6k stars 721 forks source link

solve bug with no distortion #381

Closed BenjaminKrummenacher closed 1 year ago

BenjaminKrummenacher commented 1 year ago

Solves bug that occurred when running 'optvi' in the maplab_console when using a calibration file with no distortion:

The nullptr which was added to cost_term_args when the distortion is of type kNoDistortion would later fail the following check, since the sizes don't match: [problem_impl.cc:293] Check failed: parameter_blocks.size() == cost_function->parameter_block_sizes().size() (9 vs. 8)

My solution avoids adding that nullptr if there is no distortion.

ethzasl-jenkins commented 1 year ago

Can one of the admins verify this patch?

ethzasl-jenkins commented 1 year ago

Test PASSed.

ethzasl-jenkins commented 1 year ago

Test PASSed.

ethzasl-jenkins commented 1 year ago

Test PASSed.

ethzasl-jenkins commented 1 year ago

Test FAILed.

ethzasl-jenkins commented 1 year ago

Test PASSed.