ethz-asl / maplab

A Modular and Multi-Modal Mapping Framework
https://maplab.asl.ethz.ch
Apache License 2.0
2.64k stars 724 forks source link

logic about heuristic sampling #416

Open uestcyile opened 1 week ago

uestcyile commented 1 week ago

In source code heuristic-sampling.cc for map-sparsification, I see the code of get score and cost for each landmark. But what confuse me is that you add score and cost, as the picture bellow shows: image To my understanding, landmark with higher socre means better quality, and lower cost also means better quality, so should we use "score minus cost" as the final quality metric instead of "score plus cost" ? And the code should be "double score_and_cost = landmark_scores[landmark_id] - landmark_costs[landmark_id];" , right ?