search

ethz-asl / maplab_dependencies

A repository holding submodules of maplab dependencies
https://github.com/ethz-asl/maplab
Apache License 2.0
20 stars 37 forks source link

gtsam devel branch #37

Closed schneith closed 6 years ago

schneith commented 9 years ago

@furgalep @simonlynen I need to use some features of the gtsam development branch for the sliding window estimator. This would require to make this repository private though as the development branch is not public. Can we do that? Or maybe we can separete the gtsam_catkin package into an own private repo?

furgalep commented 9 years ago

I have a solution for this.

I check out gtsam (from bitbucket) into my catkin workspace. Then gtsam_catkin connects to this version of gtsam (instead of doing download/compile).

Does that work for you?

If we need a different interim solution, we could grab a current snapshot of the gtsam source and make that available in a private data repo for download only by ASL people.

schneith commented 9 years ago

Locally I'm doing the same, but the build tests will then fail. We need to pass the devel branch to jenkins somehow.

schneith commented 9 years ago

I suggest to do the following: Create an ethzasl_gtsam repo to fork the gtsam repo and let the gtsam_catkin package grab it's code from this repo fixed to a specified commit hash.

This way we can easily pull in changes from upstream gtsam and control the version on the build server / default installation.

@furgalep If you agree, can you open an ethzasl_gtsam repo so I could set this up?

EDIT: It would be better to avoid the fork and maybe get an anonymous ethzasl bitbucket user that has read rights on the gtsam repo, so we can pull the source directly in the gtsam_catkin pkg.