search

ethz-asl / polygon_coverage_planning

Coverage planning in general polygons with holes.
GNU General Public License v3.0
529 stars 155 forks source link

Build error while performing patch step for 'gk_ma' #54

Closed esauortiz closed 3 years ago

esauortiz commented 3 years ago

Hi. First of all, thank you for sharing your work.

I've read an issue related to the same problem that I'm dealing with. This is how the patch step error looks like:

Built target gtsp_instances
patching file GkMa/OurHeuristic/Algorithm.cs
Hunk #2 FAILED at 33 (different line endings).
Hunk #3 FAILED at 37.
Hunk #4 FAILED at 76.
3 out of 4 hunks FAILED -- saving rejects to file GkMa/OurHeuristic/Algorithm.cs.rej

I've tried to compile the package with cmake version 3.20.4 and gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0. My question is if anyone has managed to fix this error without having to install another version of cmake or another version of ubuntu.

Thank you in advance,

Best regards, Esau

kledom commented 3 years ago

This is a duplicate of #43.

I just had the same issue with Ubuntu 20.04 (ROS Noetic) and CMake 3.21.0. For some reason CMake >3.14 does not accept the patch files anymore.

A practical workaround is to use snap to temporary use another version of CMake: 

sudo snap install cmake --channel=3.14/stable --classic
export PATH=/bin/snap:$PATH # temporary prefer snap CMake over system CMake
catkin build

I guess in the long term the patch files needs to be updated. I'll see if I can come up with a pull request in a reasonable amount of time.

(BTW: apart from that, the project is generally compatible to Ubuntu 20.04 and ros noetic.)

rikba commented 3 years ago

Thanks to @kledom the planner should be compatible with Noetic now!