search

ethz-asl / programming_guidelines

This repository contains style-guides, discussions, eclipse/emacs auto-formatter for commonly used programming languages
139 stars 38 forks source link

Switch to 100c lines #24

Closed PascalGohl closed 9 years ago

PascalGohl commented 9 years ago

I think it's about time to adjust to the modern bigger monitors and the explanatory variable names, which make lines really long. Any good reason against it?

pfankhauser commented 9 years ago

Here's a good argumentation. But I'm in favor of increasing the 80 characters limit.

HannesSommer commented 9 years ago

This would be almost like Christmas for me :). I would even go higher... But I can wait :).

simonlynen commented 9 years ago

I don't think we need this discussion here since the agreement was that this is handled on a per project basis, so there does not need to be lab-wide consensus.

HannesSommer commented 9 years ago

I don't think we agreed on that - at least within this repository (#11 didn't really talk about line lengths). But it seems a good idea to me. But, this PR requires a merge decision. As long as we have an eclipse formatter template in this repository, we will have a default decision encoded in it. And for that the constructive comments seem to agree. So I'll merge it.

simonlynen commented 9 years ago

@HannesSommer I don't see how an issue about tabs vs. space is giving you information about the state of the 80c/100c discussion, but since we have a separate rule for our project I don't care much what is set in the auto-formatter here, so I am fine with this being merged.

HannesSommer commented 9 years ago

It was the only issue, as far as I remember, that ended in such kind of an agreement, wasn't it? And it seems to be the only issue mentioning the magic "80" (according to github search). So I thought that for you the agreement in that issue included the 80 char lines. I had understood that differently back then. But a different interpretation according that seemed to me clearly within the uncertainty margin of human commutation.

Anyways, I really think it is a good idea to include line length in the per project decision list - far too religious as well. Is it already officially somehow differently?