NO_ROS CMake option is broken for rotors_gazebo_plugins

[Jaeyoung-Lim]

Problem Description The NO_ROS build option in rotors_gazebo_plugins appears to be broken, since some of the plugins include ROS dependencies such as mav_msgs or dynamic_reconfigure

Log:

MagneticField.proto: warning: Import quaternion.proto but not used.
[31/90] Building CXX object CMakeFiles/rotors_gazebo_noisydepth_plugin.dir/src/gazebo_noisydepth_plugin.cpp.o
FAILED: CMakeFiles/rotors_gazebo_noisydepth_plugin.dir/src/gazebo_noisydepth_plugin.cpp.o 
/usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -DMAVLINK_INTERFACE=FALSE -DROS_ASSERT_ENABLED -Drotors_gazebo_noisydepth_plugin_EXPORTS -I/usr/include/gazebo-9 -I/usr/include/bullet -I/usr/include/simbody -I/usr/include/sdformat-6.2 -I/usr/include/ignition/math4 -I/usr/include/OGRE -I/usr/include/OGRE/Terrain -I/usr/include/OGRE/Paging -I/usr/include/ignition/transport4 -I/usr/include/ignition/msgs1 -I/usr/include/ignition/common1 -I/usr/include/ignition/fuel_tools1 -I/home/jaeyoung/catkin_ws/devel/include -I/home/jaeyoung/catkin_ws/devel/include/opencv -I. -I/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/include -I/usr/include/gazebo-9/gazebo/msgs -I/usr/include/eigen3 -std=c++11 -fPIC   -std=c++11 -MD -MT CMakeFiles/rotors_gazebo_noisydepth_plugin.dir/src/gazebo_noisydepth_plugin.cpp.o -MF CMakeFiles/rotors_gazebo_noisydepth_plugin.dir/src/gazebo_noisydepth_plugin.cpp.o.d -o CMakeFiles/rotors_gazebo_noisydepth_plugin.dir/src/gazebo_noisydepth_plugin.cpp.o -c /home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_noisydepth_plugin.cpp
In file included from /home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_noisydepth_plugin.cpp:24:0:
/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/include/rotors_gazebo_plugins/gazebo_noisydepth_plugin.h:31:10: fatal error: dynamic_reconfigure/server.h: No such file or directory
 #include <dynamic_reconfigure/server.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[36/90] Building CXX object CMakeFiles/rotors_gazebo_fw_dynamics_plugin.dir/src/gazebo_fw_dynamics_plugin.cpp.o
FAILED: CMakeFiles/rotors_gazebo_fw_dynamics_plugin.dir/src/gazebo_fw_dynamics_plugin.cpp.o 
/usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -DMAVLINK_INTERFACE=FALSE -DROS_ASSERT_ENABLED -Drotors_gazebo_fw_dynamics_plugin_EXPORTS -I/usr/include/gazebo-9 -I/usr/include/bullet -I/usr/include/simbody -I/usr/include/sdformat-6.2 -I/usr/include/ignition/math4 -I/usr/include/OGRE -I/usr/include/OGRE/Terrain -I/usr/include/OGRE/Paging -I/usr/include/ignition/transport4 -I/usr/include/ignition/msgs1 -I/usr/include/ignition/common1 -I/usr/include/ignition/fuel_tools1 -I/home/jaeyoung/catkin_ws/devel/include -I/home/jaeyoung/catkin_ws/devel/include/opencv -I. -I/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/include -I/usr/include/gazebo-9/gazebo/msgs -I/usr/include/eigen3 -std=c++11 -fPIC   -std=c++11 -MD -MT CMakeFiles/rotors_gazebo_fw_dynamics_plugin.dir/src/gazebo_fw_dynamics_plugin.cpp.o -MF CMakeFiles/rotors_gazebo_fw_dynamics_plugin.dir/src/gazebo_fw_dynamics_plugin.cpp.o.d -o CMakeFiles/rotors_gazebo_fw_dynamics_plugin.dir/src/gazebo_fw_dynamics_plugin.cpp.o -c /home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_fw_dynamics_plugin.cpp
In file included from /home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_fw_dynamics_plugin.cpp:18:0:
/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/include/rotors_gazebo_plugins/gazebo_fw_dynamics_plugin.h:24:10: fatal error: mav_msgs/default_topics.h: No such file or directory
 #include <mav_msgs/default_topics.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[37/90] Building CXX object CMakeFiles/rotors_gazebo_imu_plugin.dir/src/gazebo_imu_plugin.cpp.o
FAILED: CMakeFiles/rotors_gazebo_imu_plugin.dir/src/gazebo_imu_plugin.cpp.o 
/usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -DMAVLINK_INTERFACE=FALSE -DROS_ASSERT_ENABLED -Drotors_gazebo_imu_plugin_EXPORTS -I/usr/include/gazebo-9 -I/usr/include/bullet -I/usr/include/simbody -I/usr/include/sdformat-6.2 -I/usr/include/ignition/math4 -I/usr/include/OGRE -I/usr/include/OGRE/Terrain -I/usr/include/OGRE/Paging -I/usr/include/ignition/transport4 -I/usr/include/ignition/msgs1 -I/usr/include/ignition/common1 -I/usr/include/ignition/fuel_tools1 -I/home/jaeyoung/catkin_ws/devel/include -I/home/jaeyoung/catkin_ws/devel/include/opencv -I. -I/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/include -I/usr/include/gazebo-9/gazebo/msgs -I/usr/include/eigen3 -std=c++11 -fPIC   -std=c++11 -MD -MT CMakeFiles/rotors_gazebo_imu_plugin.dir/src/gazebo_imu_plugin.cpp.o -MF CMakeFiles/rotors_gazebo_imu_plugin.dir/src/gazebo_imu_plugin.cpp.o.d -o CMakeFiles/rotors_gazebo_imu_plugin.dir/src/gazebo_imu_plugin.cpp.o -c /home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_imu_plugin.cpp
/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_imu_plugin.cpp:33:10: fatal error: mav_msgs/default_topics.h: No such file or directory
 #include "mav_msgs/default_topics.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[39/90] Building CXX object CMakeFiles/rotors_gazebo_gps_plugin.dir/src/gazebo_gps_plugin.cpp.o
FAILED: CMakeFiles/rotors_gazebo_gps_plugin.dir/src/gazebo_gps_plugin.cpp.o 
/usr/bin/c++  -DLIBBULLET_VERSION=2.87 -DLIBBULLET_VERSION_GT_282 -DMAVLINK_INTERFACE=FALSE -DROS_ASSERT_ENABLED -Drotors_gazebo_gps_plugin_EXPORTS -I/usr/include/gazebo-9 -I/usr/include/bullet -I/usr/include/simbody -I/usr/include/sdformat-6.2 -I/usr/include/ignition/math4 -I/usr/include/OGRE -I/usr/include/OGRE/Terrain -I/usr/include/OGRE/Paging -I/usr/include/ignition/transport4 -I/usr/include/ignition/msgs1 -I/usr/include/ignition/common1 -I/usr/include/ignition/fuel_tools1 -I/home/jaeyoung/catkin_ws/devel/include -I/home/jaeyoung/catkin_ws/devel/include/opencv -I. -I/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/include -I/usr/include/gazebo-9/gazebo/msgs -I/usr/include/eigen3 -std=c++11 -fPIC   -std=c++11 -MD -MT CMakeFiles/rotors_gazebo_gps_plugin.dir/src/gazebo_gps_plugin.cpp.o -MF CMakeFiles/rotors_gazebo_gps_plugin.dir/src/gazebo_gps_plugin.cpp.o.d -o CMakeFiles/rotors_gazebo_gps_plugin.dir/src/gazebo_gps_plugin.cpp.o -c /home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_gps_plugin.cpp
/home/jaeyoung/src/PX4-Autopilot/Tools/rotors_simulator/rotors_gazebo_plugins/src/gazebo_gps_plugin.cpp:22:10: fatal error: mav_msgs/default_topics.h: No such file or directory
 #include "mav_msgs/default_topics.h"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
[40/90] Building CXX object CMakeFiles/LiftDragPlugin.dir/src/liftdrag_plugin/liftdrag_plugin.cpp.o
ninja: build stopped: subcommand failed.
FAILED: external/Stamp/rotors_simulator/rotors_simulator-build 
cd /home/jaeyoung/src/PX4-Autopilot/build/px4_sitl_default/build_rotors_simulator && /usr/bin/cmake --build .
ninja: build stopped: subcommand failed.
Makefile:224: recipe for target 'px4_sitl' failed
make: *** [px4_sitl] Error 1

Expected Outcome If a NO_ROS=TRUE is passed only the plugins that do not have a ROS dependency is built