search

ethz-asl / rovio

Other
1.12k stars 504 forks source link

Build variables remain unchanged #211

Closed scharalambous3 closed 5 years ago

scharalambous3 commented 5 years ago

Dear ROVIO team, Thank you for your amazing project. I am writing to you with regards to the performance of feature tracking on my dataset: Using a static rosbag, the feature tracking selects very few features (25)

Even though I build rovio from scratch using "catkin build rovio --cmake-args -DROVIO_PATCHSIZE=4 -DROVIO_NMAXFEATURE=250 -DCMAKE_BUILD_TYPE=Release", the selected features remain 25.

Using "ccmake ." in the build/rovio folder shows both parameters having the values of 250 and 4 respectively. However, upon running rosrun rovioli (...) the features are still 25 in the frame visualization

Thus, I am afraid this is the main reason my normal rosbag diverges after 15 seconds. This is a screenshot of the frame visualization: Rovio (2)

I am looking forward to your response about how to resolve this issue

For your reference, the dataset is outdoors and sub-urban/ rural

https://drive.google.com/file/d/1C3DcaupCU35kH_mNZrUryEu9I_7VJ9Jr/view?usp=sharing

scharalambous3 commented 5 years ago

The problem was in the maplab implementation of rovio ( In rovioli these parameters are overwritten by static variables). [closed]