ethz-asl / segmap

A map representation based on 3D segments
BSD 3-Clause "New" or "Revised" License
1.06k stars 393 forks source link

Take octomap file as target cloud. #11

Closed lorenwel closed 7 years ago

lorenwel commented 7 years ago

Decides based on file extension which load function to use.

rdube commented 7 years ago

@lorenwel nice that will be handy! :) I am not sure although if we want to have the base segmatch repo to depend on octomap. Are there other situations where dependency on octomap is needed (for segmatch, not for the higher level mapper)? This could also be converted in a separate tool to load an octomap and save it as .ply. Maybe less convenient but would reduce dependencies. @HannesSommer do you have an opinion on this?

lorenwel commented 7 years ago

Sure I can make it a separate tool. I don't think a dependency on octomap is required anywhere else in segmatch. Do you want to create a separate laser_mapper_tools repo? I could also put the laser_track to octomap conversion in there. That will obviously depend on octomap as well.

rdube commented 7 years ago

Sounds good! Lets make it a laser_slam_tools package in the laser_slam repo. We can latter see how these tools evolve and if we want to group some of them in a specific package.

rdube commented 7 years ago

@lorenwel can we close this and delete the branch?

lorenwel commented 7 years ago

Yup