search

ethz-asl / segmap

A map representation based on 3D segments
BSD 3-Clause "New" or "Revised" License
1.06k stars 394 forks source link

Remove the segmatch dependency to laser_slam #72

Open rdube opened 6 years ago

rdube commented 6 years ago

The goal is to remove that dependency: https://github.com/ethz-asl/segmatch/blob/master/segmatch/package.xml#L21

This should easily be done by moving the definitions of laser_slam/include/common.h to a separate package which could be in this repository: https://github.com/ethz-asl/laser_slam/blob/master/laser_slam/include/laser_slam/common.hpp

I would suggest to wait until we open source the latest segmatch version.

rdube commented 6 years ago

@dotPiano fyi this is what we discussed about. It also involves the benchmarker which you developed so a good opportunity for you to commit this code.

brunoeducsantos commented 5 years ago

@rdube Has a separate SegMatch repository been created ( without laser_slam dependencies )?