search

ethz-asl / segmap

A map representation based on 3D segments
BSD 3-Clause "New" or "Revised" License
1.06k stars 394 forks source link

removed dependency to opencv #83

Closed rdube closed 6 years ago

rdube commented 6 years ago

@danieldugas we should reactivate jenkins to test the build. Can you please check whether that builds on your side and merge if so? thanks!

danieldugas commented 6 years ago

I'm getting an unrelated error from a dependency (nav_msgs/OccupancyGrid.h: No such file or directory in ethzasl_gridmap_2d), doesn't seem to be due to this. I'll let you know when it compiles.

rdube commented 6 years ago

@danieldugas yes this is unrelated so I will merge this PR. Did you get this error when compiling segmapper? not sure why this is a dependency.

smauq commented 6 years ago

@rdube @danieldugas You removed the dependency from the package xml, but opencv headers are still loaded here for example https://github.com/ethz-asl/segmap/blob/95579a57ca039602aba9dec57521e69013591ccf/segmatch/include/segmatch/segmatch.hpp#L9-L10 Shouldn't those includes be removed as well?

rdube commented 6 years ago

@smauq good catch!! I have removed these in #85. Should be good now. In case you find more artifacts, feel free to remove them!