search

ethz-asl / terrain-navigation

Repository for Safe Low Altitude Navigation in steep terrain for fixed-wing Aerial Vehicles
https://ieeexplore.ieee.org/abstract/document/10443502
BSD 3-Clause "New" or "Revised" License
95 stars 10 forks source link

Depend on gdal where it's used with rosdep #10

Closed Ryanf55 closed 8 months ago

Ryanf55 commented 8 months ago

Rosdep has support for gdal through three packages.

libgdal-dev has the header files, libraries, and cmake files. IT depends on gdal-bin. gdal-bin is the runtime libraries. python3-gdal is the pyhon part of gdal.

Since these are all used, they can be distributed by the package.xml.

The purpose of doing this is to remove the need to manually install libgdal-dev, which is only a useful instruction on ubuntu. For all the other platforms that can run ROS1, they need different instructions, which is hard to maintain. Rosdep is the standard and platform-independent way to manage dependencies in ROS 1 and ROS 2.

To find the sources, I searched here: https://github.com/search?q=repo%3Aros%2Frosdistro%20gdal&type=code

One thing I noticed is that terrain_planner references gdal in the CMakeLists, however it's not actually used there. If the package isn't used, perhaps it doesn't need to be found and linked to. This increases build time, code maintenance, and coupling. Consider removing it from terrain_planner?

Jaeyoung-Lim commented 8 months ago

One thing I noticed is that terrain_planner references gdal in the CMakeLists, however it's not actually used there. If the package isn't used, perhaps it doesn't need to be found and linked to. This increases build time, code maintenance, and coupling. Consider removing it from terrain_planner?

Done in https://github.com/ethz-asl/terrain-navigation/pull/11 :grin: