ethz-asl / time_stamper

Camera calibration tool
12 stars 2 forks source link

Improve Configuration #7

Closed 4c3y closed 2 years ago

4c3y commented 2 years ago

In case this code is still up for debate or as a recommendation for the future: Try to avoid repeating string literals in your code base. Consider enum class types instead or, if string literals are also printed, think of having const char * constants that you can use. Both ways the compiler can detect typos or similar mistakes which it can't in you current approach.

_Originally posted by @HannesSommer in https://github.com/ethz-asl/time_stamper/pull/5#discussion_r867669598_