ethz-asl / wavemap

Fast, efficient and accurate multi-resolution, multi-sensor 3D occupancy mapping
https://ethz-asl.github.io/wavemap/
BSD 3-Clause "New" or "Revised" License
457 stars 42 forks source link

Improve Rviz plugin usability and performance #13

Closed victorreijgwart closed 1 year ago

victorreijgwart commented 1 year ago

This PR proposes a full rewrite of the Rviz plugin, to improve performance and ease of use.

New features:

Removed features:

victorreijgwart commented 1 year ago

Testing with GCC's Thread Sanitizer is currently failing in GitHub actions, as the linker fails to find libtsan_preinit.o. The file seems to have disappeared in a recent update. The issue is reproducible on local machines running 20.04 with up-to-date apt packages.

The issue matches this Ubuntu bug report: https://bugs.launchpad.net/ubuntu/+source/gcc-10/+bug/2029910

Hopefully, it will be fixed soon. Otherwise the best option is probably to ignore TSAN and move ahead with the merge once I addressed your comments. This should be safe given that this PR introduces no threading related changes.

victorreijgwart commented 1 year ago

/prepare-release minor

victorreijgwart commented 1 year ago

Have a quick look over the comments I've added but otherwise looks good to me.

Thanks for reviewing!