search

ethz-asl / wavemap

Fast, efficient and accurate multi-resolution, multi-sensor 3D occupancy mapping
https://ethz-asl.github.io/wavemap/
BSD 3-Clause "New" or "Revised" License
457 stars 41 forks source link

Refactoring into the KISS-ICP file structure #47

Closed Divelix closed 1 year ago

Divelix commented 1 year ago

Description

This PR contains from scratch restructuring wavemap project that will allow simultaneous support for ROS1, ROS2 and Python wrappers following the example of kiss-icp project.

victorreijgwart commented 1 year ago

Thank you for proposing this new structure. However, I'll close this PR. Since it deletes everything and then adds back a small subset as new files, instead of modifying the code with change tracking, the usual review tools and PR change view can't be used. I'll go through the changes on Divelix:agnostic repo and manually compare them to the original code. Regarding your comment in the ros2 discussion thread, it's not necessary to open a PR to notify people. The work is much appreciated, and already well-advertised through both a dedicated GH Issue and a Discussion.