ethz-asl / wavemap

Fast, efficient and accurate multi-resolution, multi-sensor 3D occupancy mapping
https://ethz-asl.github.io/wavemap/
BSD 3-Clause "New" or "Revised" License
457 stars 41 forks source link

need to include <optional> for std::optional #50

Closed lucasw closed 11 months ago

lucasw commented 12 months ago

Description

Need to include for std::optional on newer Ubuntu version/s.

Type of change

Delete options that are not relevant.

Detailed summary

When building with Ubuntu 23.10 with catkin:

/home/lucasw/catkin_ws/src/misc/wavemap/wavemap/libraries/wavemap/include/wavemap/config/param.h:34:8: error: ‘optional’ in namespace ‘std’ does not name a template type
   34 |   std::optional<T> get() const {
      |        ^~~~~~~~
/home/lucasw/catkin_ws/src/misc/wavemap/wavemap/libraries/wavemap/include/wavemap/config/param.h:11:1: note: ‘std::optional’ is defined in header ‘<optional>’; did you forget to ‘#include <optional>’?
   10 | #include "wavemap/utils/meta/type_utils.h"
  +++ |+#include <optional>

Fixes # (issue)

Testing

System information (please complete if relevant):

Checklist:

lucasw commented 12 months ago

There are a few more of these, I'm going to add some more commits then will take out of draft.

lucasw commented 12 months ago

Ogre changes aren't necessary but easy to fix and I think backwards compatible (see what CI says)

In file included from /home/lucasw/catkin_ws/src/misc/wavemap/wavemap/ros/wavemap_rviz_plugin/include/wavemap_rviz_plugin/visuals/slice_visual.h:11,
                 from /home/lucasw/catkin_ws/src/misc/wavemap/wavemap/ros/wavemap_rviz_plugin/src/visuals/slice_visual.cc:1:
/usr/include/OGRE/OgreVector3.h:2:62: note: ‘#pragma message: /usr/include/OGRE/OgreVector3.h is deprecated, migrate to Ogre.h’
    2 | #pragma message( __FILE__ " is deprecated, migrate to Ogre.h")
      |       

From libogre-1.12-dev

victorreijgwart commented 11 months ago

/prepare-release patch