This PR fixes compilation errors in the Livox pointcloud callback of wavemap's ROS server.
Type of change
[x] Bug fix
Detailed summary
The errors were caused by two type names in the Livox pointcloud callback code not being updated after the refactoring for wavemap 2.0. They didn't show up during testing because this code path only gets compiled if catkin detects that the livox_ros_driver2 package is available.
Fixes #67
Testing
The code changes solve the problem on our personal machines (Ubuntu 20.04 and ROS1 noetic).
The CI pipeline should also be updated to test this automatically. We'll include this change in our upcoming CI refactoring, alongside tests of wavemap C++ and Python APIs on additional operating systems.
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any required changes in dependencies have been committed and pushed
victorreijgwart
commented
3 months ago
Description
This PR fixes compilation errors in the Livox pointcloud callback of wavemap's ROS server.
Type of change
Detailed summary
The errors were caused by two type names in the Livox pointcloud callback code not being updated after the refactoring for wavemap 2.0. They didn't show up during testing because this code path only gets compiled if catkin detects that the
livox_ros_driver2package is available.Fixes #67
Testing
The code changes solve the problem on our personal machines (Ubuntu 20.04 and ROS1 noetic). The CI pipeline should also be updated to test this automatically. We'll include this change in our upcoming CI refactoring, alongside tests of wavemap C++ and Python APIs on additional operating systems.
Checklist: