search

ethz-let / moodle-quizaccess_wifiresilience

2 stars 1 forks source link

Last version for MOODLE_401_STABLE doesn't work: wrong class names #4

Open moodleulpgc opened 7 months ago

moodleulpgc commented 7 months ago

Hi, the last 4.4 version supposedly supports 401 but it uses classes like 

 use mod_quiz\local\access_rule_base;
 use mod_quiz\quiz_settings;

Those classes don't exist in moodle 4.1 (MOODLE_401_STABLE) that versions relies on mod/quiz/accessrule/accessrulebase.php yet And quiz_settings are in quizobj

nexterday commented 7 months ago

Ideally you should pick the right branch for your current version. I just updated the min required version to prevent this from happening

moodleulpgc commented 7 months ago

But you do not use supports [] in version.php, and in moodle plugins directory you declare version 4.4 of this plugin as the latest compatible with moodle 4.1. Even morem if you actually checkout branch MOODLE_401_STABLE the problem is there. For instance rule.php uses non-exisisting classes, and generate a fatal error.

moodleulpgc commented 7 months ago

Please, reopen the issue for moodle 4.1, the latest LTS version

nexterday commented 7 months ago

Please test thoroughly because this version (and any below 4.0) are not used by us anywhere, and this is due to major changes happened in the plugin in between - please use it as transitional

Benjamin-unige commented 7 months ago

Hello, made a quick fix in a PR https://github.com/ethz-let/moodle-quizaccess_wifiresilience/pull/6 there was a typo in version.php that was crashing the install of the plugin

moodleulpgc commented 7 months ago

Hi, OK I've checkedout the 401_STABLE version and this at least does not crash quizzes. I have all quizzes working again. Yes, we will test activation of the plugin in selected quizzes. Thanks for the quick correction.