search

ethz-spylab / satml-llm-ctf

Code used to run the platform for the LLM CTF colocated with SaTML 2024
https://ctf.spylab.ai
MIT License
25 stars 6 forks source link

Post to delete should maybe just be a delete #10

Closed KrystofM closed 10 months ago

KrystofM commented 11 months ago

RESTful APIs allow for the DELETE method. Quite uncommon to use POST along with /{id}/delete to delete recourses when DELETE /{id} would work just as good and there are no additional data in the JSON body request. This is just a suggestion.

dedeswim commented 11 months ago

Hi! Thanks for the suggestion. Changing this now would break the API, and adding a DELETE endpoint as an additional way to delete defenses and chats would probably make participants confused. The earliest we can revisit the API design is for the attack phase in around one month from now.

dedeswim commented 10 months ago

Hi, in the end we decided that we won't let people delete chats through the API for the attack phase, so this won't be necessary anymore.