search

etianen / django-reversion

django-reversion is an extension to the Django web framework that provides version control for model instances.
https://django-reversion.readthedocs.io
BSD 3-Clause "New" or "Revised" License
3.04k stars 489 forks source link

Migration file missing for changes introduced in v5.0.11 #962

Closed GitRon closed 9 months ago

GitRon commented 9 months ago

Hi there!

I have a checker for missing migrations in my pipeline and this found out that apparently, since v5.0.11 there's a migration file missing.

Would be great to get this added 🙂 

Migrations for 'reversion':
  /usr/local/lib/python3.12/site-packages/reversion/migrations/0003_alter_revision_options_alter_version_options.py
    - Change Meta options on revision
    - Change Meta options on version

Best regards
Ronny

GitRon commented 9 months ago

Sorry! Didnt check properly for issues. My bad 😔

etianen commented 9 months ago

It's quite frustrating that changing the Python display name of a model results in a migration... I've never understood why that's the case.

GitRon commented 9 months ago

Yes, that's true. It will never have any impact on the table strucutre. Nevertheless, having the check in your CI is a huge improvement. Couldn't live without it anymore 🙃