etianen / django-s3-storage

Django Amazon S3 file storage.
BSD 3-Clause "New" or "Revised" License
412 stars 94 forks source link

Use Django's system check instead of a log warning #156

Closed jnns closed 1 year ago

jnns commented 1 year ago

This allows silencing the warning in case the user knows what they are doing.

The check for AWS_S3_BUCKET_NAME is left untouched because it looks like even checks of level Error or Critical can be silenced. Raising an exception seems like the better option to me.

Closes #153.

etianen commented 1 year ago

Nice. I've tweaked this a bit in #157, and will push out a release today.

etianen commented 1 year ago

Closing this in favor of discussion in #157. Your contribution would be appreciated!