Attempt to improve special characters handling in query escaping

etianen / django-watson

Full-text multi-table search application for Django. Easy to install and use, with good performance.

BSD 3-Clause "New" or "Revised" License

1.2k stars 129 forks source link

Attempt to improve special characters handling in query escaping #155

Closed JirkaV closed 8 years ago

JirkaV commented 8 years ago

Attempt to improve handling special chars in query escaping. Tested on SQLite3, PostgreSQL and MySQL, referenced in https://github.com/etianen/django-watson/issues/146

Mind you, I'm no search expert so this may be a completely wrong approach. Feel free to completely reject.

etianen commented 8 years ago

Nice! I've added a couple of line comments where I think tweaks need to be made.

Appreciate the comprehensive tests!

amureki commented 8 years ago

@etianen @JirkaV hey,

thanks for that PR, can we make this real? :) Waiting for updates here (or I can just fix last things you reviewed and then we could release it?)

etianen commented 8 years ago

I'm still waiting for those changes, so if any person can sort them, I'll pull. I can't do it myself at the moment, as I'm away with very limited internet.