search

etianen / django-watson

Full-text multi-table search application for Django. Easy to install and use, with good performance.
BSD 3-Clause "New" or "Revised" License
1.2k stars 130 forks source link

removing patterns import #173

Closed SimonGreenhill closed 8 years ago

SimonGreenhill commented 8 years ago

urls.py raises the following ImportError on Django 1.10:

  File "/Users/simon/files/Projects/language5/env/lib/python2.7/site-packages/watson/urls.py", line 5, in <module>
    from django.conf.urls import url, patterns
ImportError: cannot import name patterns

... and patterns isn't needed, so this removes the offending import.

Also, I think https://github.com/etianen/django-watson/pull/148 can be closed as outdated/fixed.

SimonGreenhill commented 8 years ago

...while I'm at it, I'll update travis to the latest versions.

etianen commented 8 years ago

Thanks for looking into this!

Looks like there still errors from importing patterns in the tests. Could you fix this too? Then I'll merge.

The details are in the failed travis builds, which you should be able to get at from this pull request page.

SimonGreenhill commented 8 years ago

Right, that fixes the import error for patterns, but it looks like there's some more issues with Django 1.10. I'll see if I can look into this in the next few days.

etianen commented 8 years ago

Much appreciated! I'm stuck on another project at the moment, so happy to let you take the lead on Django 1.10 compatibility. :)

On Mon, 8 Aug 2016 at 11:54 Simon J Greenhill notifications@github.com wrote:

Right, that fixes the import error for patterns, but it looks like there's some more issues with Django 1.10. I'll see if I can look into this in the next few days.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/etianen/django-watson/pull/173#issuecomment-238203775, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFCIBgDFi9VMhaY7NoH45bs_XXxuwRks5qdwrpgaJpZM4Jd4Nw .

SimonGreenhill commented 8 years ago

Right, think I've got it, but it'd be good to have a look over this as: (a) I've had to override some settings to get the test cases to work (b) I've had to change the buildwatson command to use argparse instead of OptionParser -- this may have affected the semantics of the command. I think I've got it the same, but it'd be good for someone else to look over it and make sure.

SimonGreenhill commented 8 years ago

... and yep, (b) has caused tests to break on anything not 1.10

etianen commented 8 years ago

So, some things that will make life easier:

Move the settings overrides into https://github.com/etianen/django-watson/blob/master/src/tests/runtests.py

Drop Django 1.7 as a test target. No need to support Django 1.7 any more.

SimonGreenhill commented 8 years ago

Great, just one failure left -- related to ede900f, I've got a few long flights coming up so will see if I can get to it after them

SimonGreenhill commented 8 years ago

...and all tests pass.

etianen commented 8 years ago

Fantastic, thanks!

Sorry I took a while to merge, I was away on holiday. :)

etianen commented 8 years ago

Are there any further issues blocking django 1.10 compatibility, or shall I push out a new release?

SimonGreenhill commented 8 years ago

No blockers as far as I can see.

etianen commented 8 years ago

django-watson 1.2.3 is now out. Thanks for all your contributions!

On Mon, 22 Aug 2016 at 11:59 Simon J Greenhill notifications@github.com wrote:

No blockers as far as I can see.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/etianen/django-watson/pull/173#issuecomment-241379820, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFCKnS7nuuFPH-k1iLmWQmgEeUPsMhks5qiYEqgaJpZM4Jd4Nw .