search

etianen / django-watson

Full-text multi-table search application for Django. Easy to install and use, with good performance.
BSD 3-Clause "New" or "Revised" License
1.2k stars 130 forks source link

Fixed #182 -- split different backends escaping #183

Closed amureki closed 7 years ago

amureki commented 7 years ago

@etianen So, according to #182 we wanted to separate symbols escaping for different backends. Here is my attempt to do that.

I'm open to other suggestions/proposals.

etianen commented 7 years ago

This looks cool. I've got a few suggestions, commented inline

amureki commented 7 years ago

@etianen thanks for review! All fine with your requests, I want to contribute good code, so it will be better for everyone. :)

I'll fix this as soon as possible, and update this PR.

etianen commented 7 years ago

Cool! Hit me with a message on this pull request when you're done, otherwise I might not be notified of the changes. :)

On Mon, 31 Oct 2016 at 13:22 Rustem Sayargaliev notifications@github.com wrote:

@etianen https://github.com/etianen thanks for review! All fine with your requests, I want to contribute good code, so it will be better for everyone. :)

I'll fix this as soon as possible, and update this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etianen/django-watson/pull/183#issuecomment-257291893, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFCF64L_9KcYnKxfFCSugd_O8nf90Aks5q5euNgaJpZM4Kd3l9 .

amureki commented 7 years ago

@etianen done! :)

etianen commented 7 years ago

Thanks for sorting this!

I'll get a release out end of this week or start of next.