search

etianen / django-watson

Full-text multi-table search application for Django. Easy to install and use, with good performance.
BSD 3-Clause "New" or "Revised" License
1.2k stars 130 forks source link

Added flake8, fixed syntax, flattened package structure #187

Closed amureki closed 7 years ago

amureki commented 7 years ago

@etianen I've decided to split my work into two PR's, otherwise changes are not easily readable and understandable.

Feel free to comment or make suggestions. If everything would be fine in #186 (when it will be merged), I'll rebase this one on master, or feel free to do it by yourself if you want. 🙃

amureki commented 7 years ago

@etianen yeah, this one was based on previous PR, that's why it had tox commit also. :)

But everything is totally fine, thanks for merging!

luzfcb commented 7 years ago

@etianen one side effect of rename directory in git, is to be forced to use git log with --follow parameter, if you need see the change history of a file and not being able to do this via the github UI

git log watson/models.py
git log --follow watson/models.py

But this is not really a problem :sweat_smile:

etianen commented 7 years ago

@luzfcb - Yeah, I've been putting off the directory rename for a while, since it has a few minor side-effects, and I was lazy. :)

On the whole, it's better this way, though!