Support stringifying objects in both Python 2 & 3

etianen / django-watson

Full-text multi-table search application for Django. Easy to install and use, with good performance.

BSD 3-Clause "New" or "Revised" License

1.21k stars 129 forks source link

Support stringifying objects in both Python 2 & 3 #224

Closed danielquinn closed 7 years ago

danielquinn commented 7 years ago

Without this fix, a Python3-based admin will simply show Search object instead of self.title.

danielquinn commented 7 years ago

The tests are failing on code I didn't write. They're pep8 complaints, but I don't think I should fix them in this PR since they're unrelated.

etianen commented 7 years ago

Looks good, I’ll merge tomorrow when I’m on my desktop. GitHub has decided we can no longer merge failing pull requests on a phone. Waaaat?!

Flake8 recently updated its default rules, which has been breaking various things. Sigh....

danielquinn commented 7 years ago

Hooray! Any idea when this will make its way into PyPi?

etianen commented 7 years ago

v1.4.4 just landed!

On 25 November 2017 at 15:02, Daniel Quinn notifications@github.com wrote:

Hooray! Any idea when this will make its way into PyPi?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/etianen/django-watson/pull/224#issuecomment-346945671, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJFCJiEKzMhs0KRan4xxXJB-6h_MGWVks5s6Cv2gaJpZM4QoyH9 .